Difference between revisions of "OWASP Code review V2 Table of Contents"

From OWASP
Jump to: navigation, search
(360 Review: Coupling source code review and Testing / Hybrid Reviews)
(45 intermediate revisions by 10 users not shown)
Line 5: Line 5:
 
# Author - Eoin Keary
 
# Author - Eoin Keary
 
# Previous version to be updated:[[https://www.owasp.org/index.php/Code_Review_Guide_History]]
 
# Previous version to be updated:[[https://www.owasp.org/index.php/Code_Review_Guide_History]]
 +
'''[[CRV2_Forward|Content here]]'''
  
== Code Review Guide History ==
+
== Code Review Guide Introduction==
 
# Author - Eoin Keary
 
# Author - Eoin Keary
 
# Previous version to be updated:[[https://www.owasp.org/index.php/Code_Review_Introduction]]
 
# Previous version to be updated:[[https://www.owasp.org/index.php/Code_Review_Introduction]]
 
+
'''[[CRV2_Introduction|Content here]]'''
== Introduction ==
+
# Author - Eoin Keary
+
  
 
=== What is source code review and Static Analysis ===
 
=== What is source code review and Static Analysis ===
# Author - Zyad Mghazli
+
=== What is Code Review ===
 +
# Author - Zyad Mghazli, Eoin Keary
 
# New Section
 
# New Section
 +
''' [[CRV2_WhatIsCodeReview|Content here]]'''
  
 
=== Manual Review - Pros and Cons ===
 
=== Manual Review - Pros and Cons ===
# Author - Ashish Rao
+
# Author - Zyad Mghazli, Eoin Keary,Gary David Robinson
 
# New Section
 
# New Section
 
# Suggestion: Benchmark of different Stataic Analysis Tools  Zyad Mghazli
 
# Suggestion: Benchmark of different Stataic Analysis Tools  Zyad Mghazli
 +
# [[CRV2_ManualReviewProsCons|Put content here]]
 +
 +
=== Advantages of Code Review to Development Practices ===
 +
# Author - Gary David Robinson
 +
# New Section
 +
# [[CRV2_AdvantagesToDevPractices|Put content here]]
  
 
=== Why code review ===
 
=== Why code review ===
 
==== Scope and Objective of secure code review ====
 
==== Scope and Objective of secure code review ====
 
# Author - Ashish Rao
 
# Author - Ashish Rao
 +
# [[CRV2_WhyCodeReview|Put content here]]
  
 
=== We can't hack ourselves secure ===
 
=== We can't hack ourselves secure ===
# Author - Prathamesh Mhatre
+
# Author - Eoin Keary
 
# New Section
 
# New Section
 +
# [[CRV2_CantHackSecure|Put content here]]
  
 
=== 360 Review: Coupling source code review and Testing / Hybrid Reviews===
 
=== 360 Review: Coupling source code review and Testing / Hybrid Reviews===
# Author - Ashish Rao
+
# Author - eoin Keary
 
# New Section
 
# New Section
 +
# [[CRV2_360Review|Put content here]]
  
 
=== Can static code analyzers do it all? ===
 
=== Can static code analyzers do it all? ===
 
# Author - Ashish Rao
 
# Author - Ashish Rao
 
# New Section
 
# New Section
 +
# [[CRV2_CanStaticAnalyzersDoAll|Put content here]]
  
==Methodology==
+
=Methodology=
 
===The code review approach===
 
===The code review approach===
#Author -  Prathamesh Mhatre
+
#Author -  Open
 +
# [[CRV2_CodeReviewApproach|Put content here]]
 +
 
 
==== Preparation and context ====
 
==== Preparation and context ====
# Author - Open
+
# Author - Gary David Robinson
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Code_Review_Preparation]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Code_Review_Preparation]]
 +
# [[CRV2_PrepContext|Put content here]]
 +
 
====Application Threat Modeling====
 
====Application Threat Modeling====
#Author - Andy, Renchie Joan
+
#Author - Larry Conklin
 
# Previous version to be updated: [[https://www.owasp.org/OCRG1.1:Application_Threat_Modeling]]
 
# Previous version to be updated: [[https://www.owasp.org/OCRG1.1:Application_Threat_Modeling]]
 +
# [[CRV2_AppThreatModeling|Put content here]]
 +
 
====Understanding Code layout/Design/Architecture====
 
====Understanding Code layout/Design/Architecture====
#Author - Ashish Rao
+
#Author - Open
 +
# [[CRV2_CodeLayoutDesignArch|Put content here]]
 +
 
 
===SDLC Integration===
 
===SDLC Integration===
#Author - Andy, Ashish Rao
+
#Author - Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Security_Code_Review_in_the_SDLC]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Security_Code_Review_in_the_SDLC]]
 +
# [[CRV2_SDLCInt|Put content here]]
 +
 
====Deployment Models====
 
====Deployment Models====
 
=====Secure deployment configurations=====
 
=====Secure deployment configurations=====
#Author - Ashish Rao
+
#Author - Open
 +
# [[CRV2_SecDepConfig|Put content here]]
 +
 
 
# New Section
 
# New Section
 
=====Metrics and code review=====
 
=====Metrics and code review=====
#Author - Andy
+
#Author - Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Code_Review_Metrics]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Code_Review_Metrics]]
 +
# [[CRV2_MetricsCodeRev|Put content here]]
 +
 
=====Source and sink reviews=====
 
=====Source and sink reviews=====
#Author - Ashish Rao
+
#Author - Open
 
# New Section
 
# New Section
 +
# [[CRV2_SourceSinkRev|Put content here]]
 +
 
=====Code review Coverage=====
 
=====Code review Coverage=====
 
#Author - Open
 
#Author - Open
 
#Previous version to be updated: [[https://www.owasp.org/index.php/Code_Review_Coverage]]
 
#Previous version to be updated: [[https://www.owasp.org/index.php/Code_Review_Coverage]]
 +
# [[CRV2_CodeRevCoverage|Put content here]]
 +
 
=====Design Reviews=====
 
=====Design Reviews=====
 
#Author - Ashish Rao
 
#Author - Ashish Rao
Line 71: Line 100:
 
**Design Areas to be reviewed
 
**Design Areas to be reviewed
 
**Common Design Flaws
 
**Common Design Flaws
 +
# [[CRV2_DesignRev|Put content here]]
 +
 
=====A Risk based approach to code review=====
 
=====A Risk based approach to code review=====
#Author - Renchie Joan
+
#Author - Open
 
#New Section
 
#New Section
 
*"Doing things right or doing the right things..."
 
*"Doing things right or doing the right things..."
 
**"Not all bugs are equal
 
**"Not all bugs are equal
 +
# [[CRV2_RiskBasedApproach|Put content here]]
 +
 
====Crawling code====
 
====Crawling code====
#Author - Abbas Naderi
+
#Author - Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Crawling_Code]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Crawling_Code]]
 
*API of Interest:
 
*API of Interest:
Line 91: Line 124:
 
#New Section
 
#New Section
 
*Searching for code in C/C++
 
*Searching for code in C/C++
#Author - Gaz Robinson
+
#Author - Gary David Robinson
 +
 
 +
# [[CRV2_CrawlingCode|Put content here]]
 +
 
 
====Code reviews and Compliance====
 
====Code reviews and Compliance====
#Author -Manual Harti
+
#Author -Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Code_Reviews_and_Compliance]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Code_Reviews_and_Compliance]]
 +
# [[CRV2_CodeRevCompliance|Put content here]]
  
==Reviewing by Techincal Control==
+
=Reviewing by Technical Control=
 
===Reviewing code for Authentication controls===
 
===Reviewing code for Authentication controls===
#Author - Anand Prakash, Joan Renchie
+
#Author - Open
 +
# [[CRV2_AuthControls|Put content here]]
 +
 
 
====Forgot password====
 
====Forgot password====
#Author Abbas Naderi
+
#Author Abbas Naderi, Larry Conklin
 +
# [[CRV2_ForgotPassword|Put content here]]
 +
 
 
====Authentication====
 
====Authentication====
#Author - Anand Prakash, Joan Renchie
+
#Author - Open
====CAPTHCA====
+
# [[CRV2_Authentication|Put content here]]
 +
 
 +
====CAPTCHA====
 
#Author Larry Conklin, Joan Renchie
 
#Author Larry Conklin, Joan Renchie
 +
'''[[CRV2_CAPTCHA|Content here]]'''
 +
 
====Out of Band considerations====
 
====Out of Band considerations====
 
#Author - Open
 
#Author - Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Authentication]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Authentication]]
 +
# [[CRV2_OutofBand|Put content here]]
 +
 
===Reviewing code Authorization weakness===
 
===Reviewing code Authorization weakness===
#Author Ashish Rao
+
#Author Eoin Keary .NET MVC added
 +
# [[CRV2_AuthorizationWeaknesses|Put content here]]
 +
 
 
====Checking authz upon every request====
 
====Checking authz upon every request====
#Author - Abbas Naderi, Joan Renchie
+
#Author - Abbas Naderi
 +
# [[CRV2_CheckAuthzEachRequest|Put content here]]
 +
 
 
====Reducing the attack surface====
 
====Reducing the attack surface====
#Author Chris Berberich
+
#Author Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Authorization]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Authorization]]
 +
# [[CRV2_ReducingAttSurf|Put content here]]
 +
 +
====SSL/TLS Implementations====
 +
#Author - Eoin Keary
 +
# [[CRV2_SSL-TLS|Put content here]]
 +
 
====Reviewing code for Session handling====
 
====Reviewing code for Session handling====
#Author - Palak Gohil, Abbas Naderi
+
#Author - Abbas Naderi
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Session-Management]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Session-Management]]
 +
# [[CRV2_SessionHandling|Put content here]]
 +
 
====Reviewing client side code====
 
====Reviewing client side code====
 
#New Section
 
#New Section
 +
# [[CRV2_ClientSideCodeIntro|Put content here]]
 +
 
=====Javascript=====
 
=====Javascript=====
 
#Author - Abbas Naderi
 
#Author - Abbas Naderi
 +
# [[CRV2_ClientSideCodeJScript|Put content here]]
 +
 
=====JSON=====
 
=====JSON=====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_ClientSideCodeJSon|Put content here]]
 +
 
=====Content Security Policy=====
 
=====Content Security Policy=====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_ClientSideCodeContSecPolicy|Put content here]]
 +
 
====="Jacking"/Framing=====
 
====="Jacking"/Framing=====
#Author - Abbas Naderi
+
#Author - Eoin  Keary
 +
# [[CRV2_ClientSideCodeJackingFraming|Put content here]]
 +
 
 
=====HTML 5?=====
 
=====HTML 5?=====
#Author - Sebastien Gioria
+
#Author - Open
 +
# [[CRV2_ClientSideCodeHTML5|Put content here]]
 +
 
 
=====Browser Defenses policy=====
 
=====Browser Defenses policy=====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_ClientSideCodeBrowserDefPol|Put content here]]
 +
 
=====etc...=====
 
=====etc...=====
 +
 
====Review code for input validation====
 
====Review code for input validation====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_InputValIntro|Put content here]]
 +
 
=====Regex Gotchas=====
 
=====Regex Gotchas=====
#Author - Abbas Naderi
+
#Author - Open
 
#New Section
 
#New Section
 +
# [[CRV2_InputValRegexGotchas|Put content here]]
 +
 
=====ESAPI=====
 
=====ESAPI=====
#Author - Abbas Naderi
+
#Author - Open
 
#New Section
 
#New Section
 
# Internal Link: [[https://www.owasp.org/index.php/Codereview-Input_Validation]]
 
# Internal Link: [[https://www.owasp.org/index.php/Codereview-Input_Validation]]
 +
# [[CRV2_InputValESAPI|Put content here]]
 +
 
====Reviewing code for contextual encoding====
 
====Reviewing code for contextual encoding====
 +
[[Overall approach to content encoding and anti XSS]]
 
=====HTML Attribute=====
 
=====HTML Attribute=====
#Author - Shenai Silva
+
#Author - Eoin Keary
 +
# [[CRV2_ContextEncHTMLAttribute|Put content here]]
 +
 
 
=====HTML Entity=====
 
=====HTML Entity=====
#Author - Shenai Silva
+
#Author - Eoin Keary
 +
# [[CRV2_ContextEncHTMLEntity|Put content here]]
 +
 
 
=====Javascript Parameters=====
 
=====Javascript Parameters=====
#Author - Open
+
#Author - Eoin Keary
 +
# [[CRV2_ContextEncJscriptParams|Put content here]]
 +
 
 
=====JQuery=====
 
=====JQuery=====
#Author - Abbas Naderi
+
#Author - Open
 +
# [[CRV2_ContextEncJQuery|Put content here]]
 +
 
 
====Reviewing file and resource handling code====
 
====Reviewing file and resource handling code====
 
#Author - Open
 
#Author - Open
=====Resource Exhaustion - error handling====
+
# [[CRV2_FileResourceHandling|Put content here]]
#Author - Abbas Naderi
+
 
 +
====Resource Exhaustion - error handling====
 +
#Author - Open
 +
# [[CRV2_ResourceExhaustionErrHandling|Put content here]]
 +
 
 
=====native calls=====
 
=====native calls=====
#Author Abbas Naderi
+
#Author Open
 +
# [[CRV2_ResourceExhaustionNativeCalls|Put content here]]
 +
 
 
====Reviewing Logging code - Detective Security====
 
====Reviewing Logging code - Detective Security====
#Author - Palak Gohil
+
#Author - Open
 
* Where to Log
 
* Where to Log
 
* What to log
 
* What to log
Line 164: Line 259:
 
* How to log
 
* How to log
 
# Internal link: [[https://www.owasp.org/index.php/Logging_Cheat_Sheet]]
 
# Internal link: [[https://www.owasp.org/index.php/Logging_Cheat_Sheet]]
 +
# [[CRV2_LoggingCode|Put content here]]
 +
 
====Reviewing Error handling and Error messages====
 
====Reviewing Error handling and Error messages====
#Author - Open
+
#Author - Gary David Robinson
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Error-Handling]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Error-Handling]]
 +
# [[CRV2_ErrorHandlingMessages|Put content here]]
 +
 
====Reviewing Security alerts====
 
====Reviewing Security alerts====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_SecurityAlerts|Put content here]]
 +
 
====Review for active defense====
 
====Review for active defense====
 
#Author - Colin Watson
 
#Author - Colin Watson
 +
# [[CRV2_ActiveDefense|Put content here]]
 +
 
====Reviewing Secure Storage====
 
====Reviewing Secure Storage====
#Author - Azzeddine Ramrami
+
#Author - Open source
 
# New Section
 
# New Section
 +
# [[CRV2_SecureStorage|Put content here]]
 +
 
====Hashing & Salting - When, How and Where====
 
====Hashing & Salting - When, How and Where====
 
=====Encrpyption=====
 
=====Encrpyption=====
Line 180: Line 285:
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Cryptographic_Controls]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Codereview-Cryptographic_Controls]]
 
*''Can we talk about key storage as well i.e. key management for encryption techniques used in the application? - Ashish Rao''
 
*''Can we talk about key storage as well i.e. key management for encryption techniques used in the application? - Ashish Rao''
==Reviewing by Vulnerability==
+
'''[[CRV2_HashingandSaltingdotNet|Content here]]'''
 +
 
 +
=Reviewing by Vulnerability=
 
===Review Code for XSS===
 
===Review Code for XSS===
#Author Palak Gohil, Anand Prakash
+
#Author Examples added by Eoin Keary
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Reviewing_Code_for_Cross-Site_Scripting]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Reviewing_Code_for_Cross-Site_Scripting]]
 
# In reviewing code for XSS - we can give more patterns on "source to sink" patterns for ASP.NET wrf to difference versions and mechanisms to display data in a page - Ashish Rao
 
# In reviewing code for XSS - we can give more patterns on "source to sink" patterns for ASP.NET wrf to difference versions and mechanisms to display data in a page - Ashish Rao
 +
# [[CRV2_RevCodeXSS|Put content here]]
 +
 
===Persistent - The Anti pattern===
 
===Persistent - The Anti pattern===
#Author Abbas Naderi
+
#Author  
 +
# [[CRV2_RevCodePersistentAntiPatternIntro|Put content here]]
 +
 
 
====.NET====
 
====.NET====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel, Eoin Keary
 +
# [[CRV2_RevCodePersistentAntiPatterndotNet|Put content here]]
 +
 
 
====.Java====
 
====.Java====
#Author Palak Gohil
+
#Author Johanna Curiel
 +
# [[CRV2_RevCodePersistentAntiPatternJava|Put content here]]
 +
 
 
====PHP====
 
====PHP====
#Author Mohammed Damavandi, Abbas Naderi
+
#Author Abbas Naderi
 +
# [[CRV2_RevCodePersistentAntiPatternPHP|Put content here]]
 +
 
 
====Ruby====
 
====Ruby====
#Author Chris Berberich
+
#Author OPen
 +
# [[CRV2_RevCodePersistentAntiPatternRuby|Put content here]]
 +
 
 
===Reflected - The Anti pattern===
 
===Reflected - The Anti pattern===
 +
# [[CRV2_RevCodeReflectedAntiPatternIntro|Put content here]]
 +
 
====.NET====
 
====.NET====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_RevCodeReflectedAntiPatterndotNet|Put content here]]
 +
 
 
====.Java====
 
====.Java====
#Author Palak Gohil
+
#Author Johanna Curiel
 +
# [[CRV2_RevCodeReflectedAntiPatternJava|Put content here]]
 +
 
 
====PHP====
 
====PHP====
#Author Mohammed Damavandi, Abbas Naderi
+
#Author Abbas Naderi
 +
# [[CRV2_RevCodeReflectedAntiPatternPHP|Put content here]]
 +
 
 
====Ruby====
 
====Ruby====
 +
# Author - Open
 +
# [[CRV2_RevCodeReflectedAntiPatternIRuby|Put content here]]
 +
 
===Stored - The Anti pattern===
 
===Stored - The Anti pattern===
 +
# Author - Open
 +
# [[CRV2_RevCodeStoredAntiPatternIntro|Put content here]]
 +
 
====.NET====
 
====.NET====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_RevCodeStoredAntiPatterndotNET|Put content here]]
 +
 
 
====.Java====
 
====.Java====
#Author Palak Gohil
+
#Author Johanna Curiel
 +
# [[CRV2_RevCodeStoredAntiPatternJava|Put content here]]
 +
 
 
====PHP====
 
====PHP====
#Author Mohammed Damavandi, Abbas Naderi
+
#Author Abbas Naderi
 +
# [[CRV2_RevCodeStoredAntiPatternPHP|Put content here]]
 +
 
 
====Ruby====
 
====Ruby====
 +
#Author - Open
 +
# [[CRV2_RevCodeStoredAntiPatternRuby|Put content here]]
 +
 
===DOM XSS ===
 
===DOM XSS ===
 
#Author Larry Conklin
 
#Author Larry Conklin
 +
# [[CRV2_DOMXSS|Put content here]]
 +
 
===JQuery mistakes===
 
===JQuery mistakes===
#Author Shenal Silva
+
#Author  
===Reviewing code for SQL Injection
+
# [[CRV2_JQueryMistakes|Put content here]]
#Author Palak Gohil, Renchie Joan
+
 
 +
===Reviewing code for SQL Injection===
 +
#Author Open
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Reviewing_Code_for_SQL_Injection]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Reviewing_Code_for_SQL_Injection]]
 +
# [[CRV2_RevCodeSQLInjection|Put content here]]
 +
 
====PHP====
 
====PHP====
#Author - Open
+
#Author - Mennouchi Islam Azeddine
 +
# [[CRV2_SQLInjPHP|Put content here]]
 +
 
 
====Java====
 
====Java====
#Author - Open
+
#Author - Johanna Curiel
 +
# [[CRV2_SQLInjJava|Put content here]]
 +
 
 
====.NET====
 
====.NET====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_SQLInjdotNET|Put content here]]
 +
 
====HQL====
 
====HQL====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_SQLInjHQL|Put content here]]
 +
 
===The Anti pattern===
 
===The Anti pattern===
 +
#Author Larry Conklin
 +
#[[CRV2_AntiPattern| Content here]]
 +
https://www.owasp.org/index.php/CRV2_AntiPattern
 
====PHP====
 
====PHP====
#Author - Mohammad Damavandi, Abbas Naderi
+
#Author -  
 +
# [[CRV2_AntiPatternPHP|Put content here]]
 +
 
 
====Java====
 
====Java====
#Author - Palak Gohil
+
#Author -  
 
#=> Searching for traditional SQL,JPA,JPSQL,Criteria,...
 
#=> Searching for traditional SQL,JPA,JPSQL,Criteria,...
 +
# [[CRV2_AntiPatternJava|Put content here]]
 +
 
====.NET====
 
====.NET====
#Author Johanna Curiel, Renchie Joan
+
#Author Open
 +
# [[CRV2_AntiPatterndotNet|Put content here]]
 +
 
 
====Ruby====
 
====Ruby====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_AntiPatternRuby|Put content here]]
 +
 
====Cold Fusion====
 
====Cold Fusion====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_AntiPatternColdFusion|Put content here]]
 +
 
===Reviewing code for CSRF Issues===
 
===Reviewing code for CSRF Issues===
#Author Palak Gohil,Anand Prakash, Abbas Naderi
+
#Author Abbas Naderi
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Reviewing_Code_for_Cross-Site_Request_Forgery]]
 
# Previous version to be updated: [[https://www.owasp.org/index.php/Reviewing_Code_for_Cross-Site_Request_Forgery]]
 +
# [[CRV2_CSRFIssues|Put content here]]
 +
 
===Transactional logic / Non idempotent functions / State Changing Functions===
 
===Transactional logic / Non idempotent functions / State Changing Functions===
 
#Author Abbas Naderi
 
#Author Abbas Naderi
 +
# [[CRV2_TransLogic|Put content here]]
 +
 
===Reviewing code for poor logic /Business logic/Complex authorization===
 
===Reviewing code for poor logic /Business logic/Complex authorization===
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_PoorLogic|Put content here]]
 +
 
===Reviewing Secure Communications===
 
===Reviewing Secure Communications===
 
====.NET Config====
 
====.NET Config====
 
#Author Johanna Curiel, Renchie Joan
 
#Author Johanna Curiel, Renchie Joan
 +
# [[CRV2_SecCommsdotNet|Put content here]]
 +
 
====Spring Config====
 
====Spring Config====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_SecCommsSpringConfig|Put content here]]
 +
 
====HTTP Headers====
 
====HTTP Headers====
#Author Gregory Disney, Abbas Naderi
+
#Author Open
 +
# [[CRV2_SecCommsHTTPHdrs|Put content here]]
 +
 
 
=====CSP=====
 
=====CSP=====
#Author Gregory Disney
+
#Author Open
 +
# [[CRV2_SecCommsHTTPHdrsCSP|Put content here]]
 +
 
 
=====HSTS=====
 
=====HSTS=====
#Author Abbas Naderi
+
#Author Open
 +
# [[CRV2_SecCommsHTTPHSTS|Put content here]]
 +
 
 
===Tech-Stack pitfalls===
 
===Tech-Stack pitfalls===
#Author Gregory Disney
+
#Author Open
 +
# [[CRV2_TechStackPitfalls|Put content here]]
 +
 
 
===Framework specific Issues===
 
===Framework specific Issues===
 
====Spring====
 
====Spring====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_FrameworkSpecIssuesSpring|Put content here]]
 +
 
====Structs====
 
====Structs====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_FrameworkSpecIssuesStructs|Put content here]]
 +
 
====Drupal====
 
====Drupal====
#Author Gregory Disney
+
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesDurpal|Put content here]]
 +
 
 
====Ruby on Rails====
 
====Ruby on Rails====
 
#Author - Open
 
#Author - Open
 +
# [[CRV2_FrameworkSpecIssuesROR|Put content here]]
 +
 
====Django====
 
====Django====
#Author Gregory Disney
+
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesDjango|Put content here]]
 +
 
 
====.NET Security / MVC====
 
====.NET Security / MVC====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel, Eoin Keary
 +
# [[CRV2_FrameworkSpecIssuesdotNetMVC|Put content here]]
 +
 
 
====Security in ASP.NET applications====
 
====Security in ASP.NET applications====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPNet|Put content here]]
 +
 
 
=====Strongly Named Assemblies=====
 
=====Strongly Named Assemblies=====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel, Larry Conklin
 +
# [[CRV2_FrameworkSpecIssuesASPNetStrongAssembiles|Put content here]]
 +
 
 
======Round Tripping======
 
======Round Tripping======
 +
# Author - Open
 +
# [[CRV2_FrameworkSpecIssuesASPNetRT|Put content here]]
 +
 
======How to prevent Round tripping======
 
======How to prevent Round tripping======
#Author Johanna Curiel, Renchie Joan
+
# Author - Open
 +
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPNetRTPrevention|Put content here]]
 +
 
 
=====Setting the right Configurations=====
 
=====Setting the right Configurations=====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPNetConfigs|Put content here]]
 +
 
 
=====Authentication Options=====
 
=====Authentication Options=====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPNetAuth|Put content here]]
 +
 
 
=====Code Review for Managed Code - .Net 1.0 and up=====
 
=====Code Review for Managed Code - .Net 1.0 and up=====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPNetManagedCode|Put content here]]
 +
 
 
=====Using OWASP Top 10 as your guideline=====
 
=====Using OWASP Top 10 as your guideline=====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPTop10|Put content here]]
 +
 
 
=====Code review for Unsafe Code (C#)=====
 
=====Code review for Unsafe Code (C#)=====
#Author Johanna Curiel, Renchie Joan
+
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPNetUnsafeCode|Put content here]]
 +
 
 
====PHP Specific Issues====
 
====PHP Specific Issues====
#Author Mohammad Damavandi, Abbas Naderi
+
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesPHP|Put content here]]
 +
 
 
====Classic ASP====
 
====Classic ASP====
 
#Author Johanna Curiel
 
#Author Johanna Curiel
 +
# [[CRV2_FrameworkSpecIssuesASPClassic|Put content here]]
 +
 
====C#====
 
====C#====
#Author Johanna Curiel, Renchie Joan
+
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesCsharp|Put content here]]
 +
 
 
====C/C++====
 
====C/C++====
#Author Gaz Robinson
+
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesCplusplus|Put content here]]
 +
 
 
====Objective C====
 
====Objective C====
 
#Author Open
 
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesObectiveC|Put content here]]
 +
 
====Java====
 
====Java====
#Author Palak Gohil
+
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesJava|Put content here]]
 +
 
 
====Android====
 
====Android====
 
#Author Open
 
#Author Open
 +
# [[CRV2_FrameworkSpecIssuesAndroid|Put content here]]
 +
 
====Coldfusion====
 
====Coldfusion====
 
#Author Open
 
#Author Open
===Security code review for Agile development===
+
# [[CRV2_FrameworkSpecIssuesColdfusion|Put content here]]
#Author Open
+
 
==Willing to review drafts==
+
====CodeIgniter====
#Terry Nerpester
+
 
#Larry Conklin
+
# Author Open
 +
# [[CRV2_FrameworkSpecIssuesCodeIgniter|Put content here]]
 +
 
 +
=Security code review for Agile development=
 +
#Author Carlos Pantelides
 +
# [[CRV2_CodeReviewAgile|Put content here]]
 +
 
 +
=Code Review Tools=
 +
https://www.owasp.org/index.php/CRV2_CodeReviewTools

Revision as of 10:46, 12 December 2013

Contents

OWASP Code Review Guide v2.0:

Forward

  1. Author - Eoin Keary
  2. Previous version to be updated:[[1]]

Content here

Code Review Guide Introduction

  1. Author - Eoin Keary
  2. Previous version to be updated:[[2]]

Content here

What is source code review and Static Analysis

What is Code Review

  1. Author - Zyad Mghazli, Eoin Keary
  2. New Section

Content here

Manual Review - Pros and Cons

  1. Author - Zyad Mghazli, Eoin Keary,Gary David Robinson
  2. New Section
  3. Suggestion: Benchmark of different Stataic Analysis Tools Zyad Mghazli
  4. Put content here

Advantages of Code Review to Development Practices

  1. Author - Gary David Robinson
  2. New Section
  3. Put content here

Why code review

Scope and Objective of secure code review

  1. Author - Ashish Rao
  2. Put content here

We can't hack ourselves secure

  1. Author - Eoin Keary
  2. New Section
  3. Put content here

360 Review: Coupling source code review and Testing / Hybrid Reviews

  1. Author - eoin Keary
  2. New Section
  3. Put content here

Can static code analyzers do it all?

  1. Author - Ashish Rao
  2. New Section
  3. Put content here

Methodology

The code review approach

  1. Author - Open
  2. Put content here

Preparation and context

  1. Author - Gary David Robinson
  2. Previous version to be updated: [[3]]
  3. Put content here

Application Threat Modeling

  1. Author - Larry Conklin
  2. Previous version to be updated: [[4]]
  3. Put content here

Understanding Code layout/Design/Architecture

  1. Author - Open
  2. Put content here

SDLC Integration

  1. Author - Open
  2. Previous version to be updated: [[5]]
  3. Put content here

Deployment Models

Secure deployment configurations
  1. Author - Open
  2. Put content here
  1. New Section
Metrics and code review
  1. Author - Open
  2. Previous version to be updated: [[6]]
  3. Put content here
Source and sink reviews
  1. Author - Open
  2. New Section
  3. Put content here
Code review Coverage
  1. Author - Open
  2. Previous version to be updated: [[7]]
  3. Put content here
Design Reviews
  1. Author - Ashish Rao
  • Why to review design?
    • Building security in design - secure by design principle
    • Design Areas to be reviewed
    • Common Design Flaws
  1. Put content here
A Risk based approach to code review
  1. Author - Open
  2. New Section
  • "Doing things right or doing the right things..."
    • "Not all bugs are equal
  1. Put content here

Crawling code

  1. Author - Open
  2. Previous version to be updated: [[8]]
  • API of Interest:
    • Java
    • .NET
    • PHP
    • RUBY
  • Frameworks:
    • Spring
    • .NET MVC
    • Structs
    • Zend
  1. New Section
  • Searching for code in C/C++
  1. Author - Gary David Robinson
  1. Put content here

Code reviews and Compliance

  1. Author -Open
  2. Previous version to be updated: [[9]]
  3. Put content here

Reviewing by Technical Control

Reviewing code for Authentication controls

  1. Author - Open
  2. Put content here

Forgot password

  1. Author Abbas Naderi, Larry Conklin
  2. Put content here

Authentication

  1. Author - Open
  2. Put content here

CAPTCHA

  1. Author Larry Conklin, Joan Renchie

Content here

Out of Band considerations

  1. Author - Open
  2. Previous version to be updated: [[10]]
  3. Put content here

Reviewing code Authorization weakness

  1. Author Eoin Keary .NET MVC added
  2. Put content here

Checking authz upon every request

  1. Author - Abbas Naderi
  2. Put content here

Reducing the attack surface

  1. Author Open
  2. Previous version to be updated: [[11]]
  3. Put content here

SSL/TLS Implementations

  1. Author - Eoin Keary
  2. Put content here

Reviewing code for Session handling

  1. Author - Abbas Naderi
  2. Previous version to be updated: [[12]]
  3. Put content here

Reviewing client side code

  1. New Section
  2. Put content here
Javascript
  1. Author - Abbas Naderi
  2. Put content here
JSON
  1. Author - Open
  2. Put content here
Content Security Policy
  1. Author - Open
  2. Put content here
"Jacking"/Framing
  1. Author - Eoin Keary
  2. Put content here
HTML 5?
  1. Author - Open
  2. Put content here
Browser Defenses policy
  1. Author - Open
  2. Put content here
etc...

Review code for input validation

  1. Author - Open
  2. Put content here
Regex Gotchas
  1. Author - Open
  2. New Section
  3. Put content here
ESAPI
  1. Author - Open
  2. New Section
  3. Internal Link: [[13]]
  4. Put content here

Reviewing code for contextual encoding

Overall approach to content encoding and anti XSS

HTML Attribute
  1. Author - Eoin Keary
  2. Put content here
HTML Entity
  1. Author - Eoin Keary
  2. Put content here
Javascript Parameters
  1. Author - Eoin Keary
  2. Put content here
JQuery
  1. Author - Open
  2. Put content here

Reviewing file and resource handling code

  1. Author - Open
  2. Put content here

Resource Exhaustion - error handling

  1. Author - Open
  2. Put content here
native calls
  1. Author Open
  2. Put content here

Reviewing Logging code - Detective Security

  1. Author - Open
  • Where to Log
  • What to log
  • What not to log
  • How to log
  1. Internal link: [[14]]
  2. Put content here

Reviewing Error handling and Error messages

  1. Author - Gary David Robinson
  2. Previous version to be updated: [[15]]
  3. Put content here

Reviewing Security alerts

  1. Author - Open
  2. Put content here

Review for active defense

  1. Author - Colin Watson
  2. Put content here

Reviewing Secure Storage

  1. Author - Open source
  2. New Section
  3. Put content here

Hashing & Salting - When, How and Where

Encrpyption
.NET
  1. Author Larry Conklin, Joan Renchie
  2. Previous version to be updated: [[16]]
  • Can we talk about key storage as well i.e. key management for encryption techniques used in the application? - Ashish Rao

Content here

Reviewing by Vulnerability

Review Code for XSS

  1. Author Examples added by Eoin Keary
  2. Previous version to be updated: [[17]]
  3. In reviewing code for XSS - we can give more patterns on "source to sink" patterns for ASP.NET wrf to difference versions and mechanisms to display data in a page - Ashish Rao
  4. Put content here

Persistent - The Anti pattern

  1. Author
  2. Put content here

.NET

  1. Author Johanna Curiel, Eoin Keary
  2. Put content here

.Java

  1. Author Johanna Curiel
  2. Put content here

PHP

  1. Author Abbas Naderi
  2. Put content here

Ruby

  1. Author OPen
  2. Put content here

Reflected - The Anti pattern

  1. Put content here

.NET

  1. Author Johanna Curiel
  2. Put content here

.Java

  1. Author Johanna Curiel
  2. Put content here

PHP

  1. Author Abbas Naderi
  2. Put content here

Ruby

  1. Author - Open
  2. Put content here

Stored - The Anti pattern

  1. Author - Open
  2. Put content here

.NET

  1. Author Johanna Curiel
  2. Put content here

.Java

  1. Author Johanna Curiel
  2. Put content here

PHP

  1. Author Abbas Naderi
  2. Put content here

Ruby

  1. Author - Open
  2. Put content here

DOM XSS

  1. Author Larry Conklin
  2. Put content here

JQuery mistakes

  1. Author
  2. Put content here

Reviewing code for SQL Injection

  1. Author Open
  2. Previous version to be updated: [[18]]
  3. Put content here

PHP

  1. Author - Mennouchi Islam Azeddine
  2. Put content here

Java

  1. Author - Johanna Curiel
  2. Put content here

.NET

  1. Author - Open
  2. Put content here

HQL

  1. Author - Open
  2. Put content here

The Anti pattern

  1. Author Larry Conklin
  2. Content here

https://www.owasp.org/index.php/CRV2_AntiPattern

PHP

  1. Author -
  2. Put content here

Java

  1. Author -
  2. => Searching for traditional SQL,JPA,JPSQL,Criteria,...
  3. Put content here

.NET

  1. Author Open
  2. Put content here

Ruby

  1. Author - Open
  2. Put content here

Cold Fusion

  1. Author - Open
  2. Put content here

Reviewing code for CSRF Issues

  1. Author Abbas Naderi
  2. Previous version to be updated: [[19]]
  3. Put content here

Transactional logic / Non idempotent functions / State Changing Functions

  1. Author Abbas Naderi
  2. Put content here

Reviewing code for poor logic /Business logic/Complex authorization

  1. Author - Open
  2. Put content here

Reviewing Secure Communications

.NET Config

  1. Author Johanna Curiel, Renchie Joan
  2. Put content here

Spring Config

  1. Author - Open
  2. Put content here

HTTP Headers

  1. Author Open
  2. Put content here
CSP
  1. Author Open
  2. Put content here
HSTS
  1. Author Open
  2. Put content here

Tech-Stack pitfalls

  1. Author Open
  2. Put content here

Framework specific Issues

Spring

  1. Author - Open
  2. Put content here

Structs

  1. Author - Open
  2. Put content here

Drupal

  1. Author Open
  2. Put content here

Ruby on Rails

  1. Author - Open
  2. Put content here

Django

  1. Author Open
  2. Put content here

.NET Security / MVC

  1. Author Johanna Curiel, Eoin Keary
  2. Put content here

Security in ASP.NET applications

  1. Author Johanna Curiel
  2. Put content here
Strongly Named Assemblies
  1. Author Johanna Curiel, Larry Conklin
  2. Put content here
Round Tripping
  1. Author - Open
  2. Put content here
How to prevent Round tripping
  1. Author - Open
  2. Author Johanna Curiel
  3. Put content here
Setting the right Configurations
  1. Author Johanna Curiel
  2. Put content here
Authentication Options
  1. Author Johanna Curiel
  2. Put content here
Code Review for Managed Code - .Net 1.0 and up
  1. Author Johanna Curiel
  2. Put content here
Using OWASP Top 10 as your guideline
  1. Author Johanna Curiel
  2. Put content here
Code review for Unsafe Code (C#)
  1. Author Johanna Curiel
  2. Put content here

PHP Specific Issues

  1. Author Open
  2. Put content here

Classic ASP

  1. Author Johanna Curiel
  2. Put content here

C#

  1. Author Open
  2. Put content here

C/C++

  1. Author Open
  2. Put content here

Objective C

  1. Author Open
  2. Put content here

Java

  1. Author Open
  2. Put content here

Android

  1. Author Open
  2. Put content here

Coldfusion

  1. Author Open
  2. Put content here

CodeIgniter

  1. Author Open
  2. Put content here

Security code review for Agile development

  1. Author Carlos Pantelides
  2. Put content here

Code Review Tools

https://www.owasp.org/index.php/CRV2_CodeReviewTools