Dead Code: Expression is Always False

From OWASP
Jump to: navigation, search


This page was marked to be reviewed for deletion.


#REDIRECT Failure to follow guideline/specification


Last revision (mm/dd/yy): 04/7/2009


Contents

Description

This expression will always evaluate to false.

This expression will always evaluate to false; the program could be rewritten in a simpler form. The nearby code may be present for debugging purposes, or it may not have been maintained along with the rest of the program. The expression may also be indicative of a bug earlier in the method.


Risk Factors

TBD


Examples

The following method never sets the variable secondCall after initializing it to false. (The variable firstCall is mistakenly used twice.) The result is that the expression firstCall && secondCall will always evaluate to false, so setUpDualCall() will never be invoked.

	public void setUpCalls() {
	  boolean firstCall = false;
	  boolean secondCall = false;
	
	  if (fCall > 0) {
		setUpFCall();
		firstCall = true;
	  }
	  if (sCall > 0) {
		setUpSCall();
		firstCall = true;
	  }
	
	  if (firstCall && secondCall) {
		setUpDualCall();
	  }
	}


Related Attacks


Related Vulnerabilities


Related Controls


Related Technical Impacts


References

TBD