Mass Assignment Cheat Sheet



{| style="padding: 0;margin:0;margin-top:10px;text-align:left;" |- Last revision (mm/dd/yy): //
 * valign="top" style="border-right: 1px dotted gray;padding-right:25px;" |

= Introduction =

Definition
Software frameworks sometime allow developers to automatically bind HTTP request parameters into program code variables or objects to make using that framework easier on developers. This can sometimes cause harm. Attackers can sometimes use this methodology to create new parameters that the developer never intended which in turn creates or overwrites new variable or objects in program code that was not intended. This is called a mass assignment vulnerability.

Alternative Names
Depending on the language/framework in question, this vulnerability can have several alternative names
 * Mass Assignment: Ruby on Rails, NodeJS
 * Autobinding: Spring MVC, ASP.NET MVC
 * Object injection: PHP

Example
Suppose there is a form for editing a user's account information:

  

Here is the object that the form is binding to:

public class User { private String userid; private String password; private String email; private boolean isAdmin; //Getters & Setters }

Here is the controller handling the request:

@RequestMapping(value = "/addUser, method = RequestMethod.POST)  public String submit(User user) {      userService.add(user);      return "successPage";   }

Here is the typical request:

POST /addUser userid=bobbytables&password=hashedpass&email=bobby@tables.com

And here is the exploit:

POST /addUser userid=bobbytables&password=hashedpass&email=bobby@tables.com&isAdmin=true

Exploitability
This functionality becomes exploitable when:
 * Attacker can guess common sensitive fields
 * Attacker has access to source code and can review the models for sensitive fields
 * AND the object with sensitive fields has an empty constructor

GitHub
In 2012, GitHub was hacked using mass assignment. A user was able to upload his public key to any organization and thus make any subsequent changes in their repositories. GitHub's Blog Post

Solutions

 * Whitelist the bindable, non-sensitive fields
 * Blacklist the non-bindable, sensitive fields
 * Use Data Transfer Objects (DTOs)

= General Solutions =

Data Transfer Objects (DTOs)
An architectural approach is to create Data Transfer Objects and avoid binding input directly to domain objects. Only the fields that are meant to be editable by the user are included in the DTO.

public class UserRegistrationFormDTO { private String userid; private String password; private String email; //private boolean isAdmin; //Getters & Setters }

= Language & Framework Specific Solutions =

Whitelisting
@Controller public class UserController {     @InitBinder public void initBinder(WebDataBinder binder, WebRequest request) {        binder.setAllowedFields(["userid","password","email"]); }     ...   }

Reference

Blacklisting
@Controller public class UserController {     @InitBinder public void initBinder(WebDataBinder binder, WebRequest request) {        binder.setDisallowedFields(["isAdmin"]); }     ...   } Reference

Whitelisting
var UserSchema = new mongoose.Schema({    userid    : String,     password  : String,     email     : String,     admin     : Boolean,   }); UserSchema.statics = { User.userCreateSafeFields: ['userid', 'password', 'email'] };  var User = mongoose.model('User', UserSchema);

_ = require('underscore'); var user = new User(_.pick(req.body, User.userCreateSafeFields));

Reference Reference

Blacklisting
var massAssign = require('mongoose-mass-assign'); var UserSchema = new mongoose.Schema({    userid    : String,     password  : String,     email     : String,     admin     : { type: Boolean, protect: true, default: false }   }); UserSchema.plugin(massAssign); var User = mongoose.model('User', UserSchema);

/** Static method, useful for creation **/ var user = User.massAssign(req.body); /** Instance method, useful for updating **/ var user = new User; user.massAssign(req.body); /** Static massUpdate method **/ var input = { name: 'bhelx', admin: 'true' }; User.update({ '_id': someId }, { $set: User.massUpdate(input) }, console.log);

Reference

Ruby On Rails
Reference

Django
Reference

ASP.NET
Reference

Whitelisting
<?php namespace App; use Illuminate\Database\Eloquent\Model; class User extends Model {     private $userid; private $password; private $email; private $isAdmin; protected $fillable = array('userid','password','email'); }

Reference

Blacklisting
<?php namespace App; use Illuminate\Database\Eloquent\Model; class User extends Model {     private $userid; private $password; private $email; private $isAdmin; protected $guarded = array('isAdmin'); }

Reference

Grails
Reference

Play
Reference

Jackson (JSON Object Mapper)
Reference Reference

GSON (JSON Object Mapper)
Reference Reference

JSON-Lib (JSON Object Mapper)
Reference

Flexjson (JSON Object Mapper)
Reference

= Authors and Primary Editors =
 * [mailto:abashkin.anton@gmail.com Abashkin Anton]

= References and future reading =
 * Mass Assignment, Rails and You http://code.tutsplus.com/tutorials/mass-assignment-rails-and-you--net-31695

= Other Cheatsheets =


 * }