Codereview-Deployment

OWASP Code Review Guide Table of Contents

Secure Application Deployment
Another important thing to be aware of is when you receive the code: make sure it is identical in deployment layout to what would go to production. Having well-written code is a great start, but deploying that great code in unprotected folders on the application server is not a great idea. Attackers do code reviews also, and what better than to code review the potential target application.

Outside of the actual code to review, one must examine if the deployment of a web application is within a secure environment. Having secure code, but the environment upon which the code resides is insecure, is a lost cause. Accessing resources directly must be controlled within the environment;

Areas such as configuration files, directories, & resources which need authorisation need to be secured on the host so that direct access to such artifacts is disallowed.

For example: try in “Google”: http://www.google.com/search?q=%0D%0Aintitle%3Aindex.of+WEB-INF

This lists exposed “Web-Inf” directories on WebSphere®, Tomcat and other app servers.

''The WEB-INF directory tree contains web application classes, pre-compiled JSP files, server side libraries, session information, and files such as web.xml and webapp.properties. ''

So be sure the code base is identical to production. Ensuring that we have a “secure code environment” is also an important part of an application secure code inspection.

The code may be “bullet proof” but if it is accessible to a user this may cause other problems. Remember the developer is not the only one to perform code reviews, attackers also do this. The only visible surface that a user should see are the “suggestions” rendered by the browser upon receiving the HTML from the backend server. Any request to the backend server outside the strict context of the application should be refused and not be visible. Generally think of “That which is not explicitly granted is denied”.

Example of the Tomcat web.xml to prevent directory indexing:

default org.apache.catalina.servlets.DefaultServlet  debug 0   listings false   readonly</param-name> true</param-value> </init-param> <load-on-startup>1</load-on-startup> So to deny access to all directories we put: <Directory /> Order Deny,Allow Deny from All </Directory>

And then override this for the directories we require access to.

Also, in Apache HTTP server, to ensure directories like WEB-INF and META-INF are protected, the following should be added to the httpd.conf, the main configuration file for the Apache web server:

<Directory /usr/users/*/public_html> Order Deny,Allow Allow from all </Directory> <Directory /usr/local/httpd> Order Deny,Allow Allow from all </Directory>

On Apache servers, if we wish to specify permissions for a directory and subdirectories we add a .htaccess file.

To protect the .htaccess file itself we place:

<Files .htaccess> order allow,deny deny from all </Files>

To stop directory indexing we place the following directive into the .htaccess file: IndexIgnore * The * is a wildcard to prevent all files from being indexed.

Protecting JSP Pages
If using the Struts framework we do not want users to access any JSP page directly. Accessing the JSP directly without going through the request processor can enable the attacker to view any server-side code in the JSP. Let's say the initial page is an HTML document, so the HTTP GET from the browser retrieves this page. Any subsequent page must go through the framework. Add the following lines to the web.xml file to prevent users from accessing any JSP page directly:

<web-app> ... <security-constraint> <web-resource-collection> <web-resource-name>no_access</web-resource-name> <url-pattern>*.jsp</url-pattern> </web-resource-collection> <auth-constraint/> </security-constraint> ... </web-app>

With this directive in web.xml an HTTP request for a JSP page directly will fail.

Protecting ASP Pages
For classic ASP pages there is no way to configure this kind of protection using a configuration file, rather these kinds of configurations can only be only done though IIS console, thus, out of the scope of this document.

A clean environment
When reviewing the environment we must see if the directories contain any artifacts from development. These files may not be referenced in any way and hence the application server gives no protection to them. Files such as .bak, .old, .tmp, etc. should be removed as they may contain source code.

Source code should not go into production directories. The compiled class files are all that is required in most cases. All source code should be removed and only the “executables” should remain.

No development tools should be present in a production environment. For example a Java application should only need a JRE (Java Runtime Environment) and not a JDK (Java Development Kit) to function.

Test and debug code should be removed from all source code and configuration files. Even commented-out code should be removed as a precaution. Test code can contain backdoors that circumvent the workflow in the application, and at worst contain valid authentication credentials or account details.

Comments on code and Meta tags pertaining to the IDE used or technology used to develop the application should be removed. Some comments can divulge important information regarding bugs in code or pointers to functionality. This is particularly important with server side code such as JSP and ASP files.

A copyright and confidentiality statement should be at the top of every file. This mitigates any confusion regarding who owns the code. This may seem trivial but it is important to state who owns the code.

To sum up, code review includes looking at the configuration of the application server and not just the code. Knowledge of the server in question is important and information is easily available on the web.